Small performance optimization of monster movement #44242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
Code: Performance
ZhilkinSerg
force-pushed
the
perf-monmove
branch
from
f7b3dd4 to
dcc0e0f
Compare
|
ahh yes the mi-go stuck in a cell performance drain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Small performance optimization of monster movement"Purpose of change
Some creatures can't move because they are surrounded by terrain/furniture/creatures, but they still try to do that and make somewhat expensive pathfinding calculations which can and should be avoided.
Describe the solution
Do not try to move monster that can't move into.
Describe alternatives you've considered
Make all monsters stationary.
Testing