Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soldering automated recipe activity level changes #44081

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

anothersimulacrum
Copy link
Member

@anothersimulacrum anothersimulacrum commented Sep 9, 2020

Summary

SUMMARY: None

Purpose of change

Split from #42873

Describe the solution

Changed all recipes using soldering to LIGHT_EXERCISE if not already
set.

@Fosheze
Copy link
Contributor

Fosheze commented Sep 9, 2020

I love all the work you've been doing on the activity levels. But as someone who has worked in electronics manufacturing and has done hand soldering for 10 hour shifts straight, I can definitively say that soldering is definitely not moderate_activity. I say this simply because walking is set at moderate_activity and walking is much more physical work than soldering. Moderate_activity is also set to burn nearly 7000 Kcal per day. I can assure you that I didn't lose weight sitting around hand soldering all day. The most intensive thing about soldering for long periods of time is trying to stave off the boredom and finger cramps.

From my experience it would be much better being set to light_activity for default. I would even argue that it should be set to no activity similar to reading for most recipes as holding a book is probably more work than soldering a couple of LEDs on a board. But because some things the survivor may be working on are heavier than your normal bit of electronics as a default light_activity seems like a good compromise.

@Zireael07
Copy link
Contributor

Yep, my Dad did a lot of soldering when he had a repair shop - doesn't burn calories at all!

Changed all recipes using soldering to LIGHT_EXERCISE if not already
set.
@anothersimulacrum
Copy link
Member Author

Thanks for the feedback!

@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Sep 9, 2020
@ZhilkinSerg ZhilkinSerg merged commit 16d68ce into CleverRaven:master Sep 9, 2020
@anothersimulacrum anothersimulacrum deleted the recime4 branch September 9, 2020 21:10
@anothersimulacrum anothersimulacrum restored the recime4 branch September 13, 2020 21:20
@anothersimulacrum anothersimulacrum deleted the recime4 branch September 15, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants