Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mutation and bionic functions from player to character #44008

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Sep 6, 2020

Summary

SUMMARY: Infrastructure "Deprecate mutation and bionic functions from player to character"

Purpose of change

#34721

Describe the solution

copy pasted a small number of functions from player.h into character.h and avatar.h. fixed the fallout, which included changing the parameters of some functions in animation.cpp to avatar.

moved the following functions:

  • has_conflicting_trait
  • has_lower_Trait
  • has_higher_trait
  • has_same_type_trait
  • purifiable
  • get_category_dream
  • power_bionics
  • power_mutations
  • bionic_by_invlet

Testing

the game runs fine.

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Sep 6, 2020
@ZhilkinSerg ZhilkinSerg merged commit 93431eb into CleverRaven:master Sep 7, 2020
@KorGgenT KorGgenT deleted the more-player-deprecation branch September 7, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants