Longest Side Audit for archery.json, 500.json, 22.json, 38.json and atgm.json #43422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found measurements on respective company websites for the two firearms in this json. https://www.bighornarmory.com/product/model-89-carbine-18-500-sw/ and https://www.smith-wesson.com/firearms/model-sw500-0
Added longest side in json using info from wikipedia
Defined longest side and weight for ruger .22 from https://ruger.com/products/lcr/specSheets/5410.html and changed longest side for ruger .38 from same site.
Arrow lengths are primarily from the largest draw length I saw in the bow descriptions (30 inch), added a bit more for explosive arrow, feel free to tweak these though. Most lengths are from bow descriptions, greatbow length is 9ft from assumption of very large mutation height.
Converted to cm because apparently the game doesn't convert mm to cm in the details screen. Changed compgreatbow to be in line with woodgreatbow "78in" description.
Merge from main fork (hopefully)
venum4k
changed the title
venum4k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Added and checked lengths for several guns, bows and arrows"
Purpose of change
Addresses some of the issues with item longest_side being inaccurate, assisting with #41691 and the bows for #43420.
Describe the solution
I added some longest_side lines to jsons and changed some numbers.
Describe alternatives you've considered
I'm not sure there are any real alternatives to inputting numbers
Testing
I checked the in-game inventory screens for updated values.
Additional context
A lot of the bow lengths were taken from the existing descriptions in the json files. Some of the gun lengths were from manufacturer websites, some educated guesses were made (hey, the numbers are probably more accurate than they were before).