Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite wetness #42430

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Fix infinite wetness #42430

merged 7 commits into from
Jul 28, 2020

Conversation

Fris0uman
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fix infinite wetness"

Purpose of change

Fixes #42364
Fixes #42422

Describe the solution

Fix typo that made you wetter each time you were supposed to dry
Add check to keep wetness between 0 and drench capacity
Fix another typo that made it impossible to wash scent with water

Describe alternatives you've considered

Testing

Load save from issue
Wait a bit
Things return to normal

Make new world
Wait in the rain

Before fix wetness increase above 100%
After fix wetness stays at 100%

Additional context

Took the opportunity to move update_body_wetness to Character as aprt of #34721

Thought about jsonizing the bonus from trati that retard getting wet but that would confuse the PR a bit too much

@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/my-torso-and-arms-warmth-drops-to-insane-levels-after-loading-a-save/24201/17

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels Jul 24, 2020
@ZhilkinSerg ZhilkinSerg merged commit 0ae7066 into CleverRaven:master Jul 28, 2020
@Fris0uman Fris0uman deleted the wetcap branch July 28, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
4 participants