Use shorter scale specifications in project_to, etc. #42317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on CleverRaven#41693 I totally forgot that I'd added shorter names for the various coord::scale values to use in project_to etc. without being so verbose. This makes the API more consistent because the names of the scales match the abbreviations in the type names. Convert to the shorter names. Strictly a find-and-replace commit, so hopefully should be safe.
ZhilkinSerg
added
[C++]
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
When working on #41693 I totally forgot that I'd added shorter names for the various
coord::scalevalues to use inproject_toetc. without being so verbose.This makes the API less verbose and more consistent because the names of the scales match the abbreviations in the type names.
Describe the solution
Convert to the shorter names.
Strictly a find-and-replace commit, so hopefully should be safe.
Describe alternatives you've considered
Leaving the long names for more clarity.
Testing
Unit tests.