Turn martial arts manuals into real books #42315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
the
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix martial arts books requiring no time to read"
Purpose of change
Fixes #42312.
The intelligence requirement and time-to-read values were not inherited from the base manual.
copy-fromdoesn't seem to work for nested fields likebook_data. All missing values are instead set to their default.Describe the solution
Changes all martial arts books to use the
BOOKtype, and specify book-related fields directly instead of usingbook_dataDescribe alternatives you've considered
Look at deserialization code to figure out how to make
copy-fromwork withbook_data.Specify
timeandintelligencedirectly on each manual.Testing
Spawn multiple martial arts books using the old JSON. Learn one of them almost instantly.
Load the game with the changed JSON and ensure the books are still read/unread like before.
Read the second book. Each chapter now takes about 10 minutes to read.