add longest_side to landscaping.json tools #41654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Add lengths to items in json\items\tool\landscaping.json"
Purpose of change
Auto generated lengths are wildly inaccurate for non cube shaped objects.
See #41621
Describe the solution
Add lengths based on realworld measurements.
Changes:
digging stick - made 90 cm/~3ft
trowel - made 25cm/10in. Measurements from trowel I own
hoe - made 140cm/~54in https://www.lowes.com/pd/CRAFTSMAN-54-in-Fiberglass-Handle-Garden-Hoe/1000761136?store_code=674
primitive shovel - made 90cm/3ft
scythe - made 140cm, lowered weight to 2140g/4.72lbs https://www.walmart.com/ip/Outdoor-Metal-Scythe-Garden-Farm-Tool-Solid-Wooden-Handle-Grass-Weed-Scythe-Grinding-Stone/277521583?wmlspartner=wlpa&selectedSellerId=101006007
shovel - made 140cm/~55in, increased weight to 2032g/4.5 lbs https://www.lowes.com/pd/CRAFTSMAN-55-in-Wood-Long-handle-Digging-Shovel/1000604755?store_code=3000
sickle - made 50cm/~18in, and 907g/2lbs https://www.hardwarefy.com/truper-serrated-sickles-18-15121/
hedge trimmer - made 100cm/40in https://www.homedepot.com/p/ECHO-20-in-21-2-cc-Gas-2-Stroke-Cycle-Hedge-Trimmer-HC-2020/306812811
Describe alternatives you've considered
Leave auto generated values.
Testing
Spawn items and check for new lengths.
Additional context