Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize JSON: Convert folded_volume to metric with units #41524

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

wapcaplet
Copy link
Contributor

@wapcaplet wapcaplet commented Jun 22, 2020

Summary

SUMMARY: Infrastructure "Modernize JSON: Convert folded_volume to metric with units"

Purpose of change

Make JSON values more readable and comprehensible.

Contributes to #36110

Describe the solution

Replaces integer values in "folded_volume" for vehicle parts with metric volume string equivalent (converting from metric cups, 250 ml).

Testing

Compiled, ran the game, used hammerspace mutation with vehicle construction menu to see folded volume of parts.

Additional context

image

image

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Jun 22, 2020
@ZhilkinSerg ZhilkinSerg merged commit d97f383 into CleverRaven:master Jun 22, 2020
@wapcaplet wapcaplet deleted the folded-volume-units branch June 23, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants