Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEMA camp rotation fix #41426

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

chaisawlajatang
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fixes FEMA camp rotation"

Purpose of change

Recently JSONified FEMA camp (#40015) had rotation issues, screenshots below really speak for themselves.

Describe the solution

Added _north suffixes, removed NO_ROTATE flag.

Describe alternatives you've considered

Slapping ""rotate": false" in the specials.json entry, forbidding the rotation.

Testing

Spawned several camps with different rotations, jumped around. Everything looks fine.

Additional context

Before
fema1

After
fema2

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jun 18, 2020
@Rivet-the-Zombie Rivet-the-Zombie merged commit cf80ae0 into CleverRaven:master Jun 19, 2020
@ZhilkinSerg
Copy link
Contributor

This one needs savegame migration fix (e.g. #30273).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants