Clang-tidy check to combine locals into points #41238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbytheway
force-pushed
the
combine_locals_into_points
branch
from
98ea6e7 to
328fdda
Compare
This is an initial implementation of the idea.
Add a test for this case, which happens to occur in the CDDA code.
When naming the new point variable, remove leading or trailing underscores from the root name, so that e.g. win_x, win_y become win.x and win.y (rather than win_.x and win_.y).
When naming the new point variable, try to avoid existing names. This check won't avoid all existing names, but it's a start.
The name derivation rules could lead to naming a variable e.g. '1', which is illegal.
The new check is quite likely to conflict with itself if making multiple edits to a single function, so prevent it from doing so.
When merging some ints into a point, if the ints were static or constexpr then the point must be also.
Doing this one separately because it required a little manual intervention.
Doing headers separately to avoid edit collisions.
jbytheway
force-pushed
the
combine_locals_into_points
branch
3 times, most recently
from
3d0b65b to
6d1d88f
Compare
jbytheway
force-pushed
the
combine_locals_into_points
branch
from
6d1d88f to
9fc62e1
Compare
|
OK, looks like the clang-3.8 issues are now resolved. |
anothersimulacrum
added
[C++]
|
Is the I think you need to write it like (I get map corruption around that line...) edit: The aforementioned change makes the load corruption go away. edit: nm fixed |
|
Thanks for catching that. Indeed it was a bad change. Did you see other similar changes? |
|
Didn't notice any on a cursory grepping. I'll keep my eyes open for further crashes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Enforce use of points as local variables"
Purpose of change
For better type safety and code clarity.
Working towards #32017.
Describe the solution
Add a new clang-tidy check that looks for pairs (or triples) of local variables that should be merged into
points (ortripoints), and automate that conversion.On average, I think these changes are a substantial improvement; lots of cases where points were being unnecessarily decomposed and recomposed are now performed as point arithmetic directly.
Describe alternatives you've considered
Doing some subset of the changes by hand.
Testing
Most of the changes are automated, so should be low-risk.
Ran the unit tests.
Additional context
I'm expecting some compiler errors from the old clang we support (3.8), so don't merge until that looks good (it's the first Travis CI job).