Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charged battery to headlamp in vision tests #40873

Merged
merged 2 commits into from
May 26, 2020

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

After #40791 some vision tests started failing because the light-providing item in the test was not charged.

Describe the solution

Load the item with a charged battery.

Describe alternatives you've considered

There might be a better solution which results in item flashlight( "flashlight_type" ) resulting in a charged item lie it did pre-nested inventory overhaul.

Testing

This will ONLY impact the vision tests, so if the vision tests start passing again we're good.

tests/vision_test.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. labels May 26, 2020
@ZhilkinSerg ZhilkinSerg merged commit cae03f6 into master May 26, 2020
@kevingranade kevingranade deleted the kevingranade-fix-vision-test branch June 24, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants