Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m books about sports #40675

Merged
merged 9 commits into from
May 21, 2020
Merged

m books about sports #40675

merged 9 commits into from
May 21, 2020

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented May 18, 2020

Summary

SUMMARY: Content "nonfiction and fictional books about sports"

Purpose of change

Add more diversity of clutter books (ie environmental props which don't contribute much to strategy, but perhaps some to story and immersion.)

Describe the solution

  • create misc_sports.json and move novel_sports to it
  • create abstracts for hard bound fiction books and fict books in general
  • create 4 abstracts for sports books: paper nonf, hard nonf, paper fict, hard fict
  • make and modify a number of SUS groups, including ...nonf_soft_sports, ...fict_soft_sports, ...nonf_hard_sports, ...fict_hard_sports, and just SUS_book_sports
  • add to some of the dudes that spawn in dead college kids psych books, sports books, or philosophy books (this is just for fun, dipping my toe in, not meant to be comprehensive)
  • add at least 13 new (non-skill) books themed as sports books

Describe alternatives you've considered

At this point it is a bit convoluted. I'm attempting to flesh out a cascading system of templates that allow for A) new books to be added with minimal effort, B) broad sets of books to updated quickly via their abstracts, and C) book stats to be standardized, at least so much as in deviations from the standard are easily noticed.

Because of some WIP that this PR will not complete, a given book "book_fict_hard_sports_uni" is slightly more likely to show up then it ought to. It's trivial: both harmless and unlikely to be noticed. The reason I'm leaving it in is to preserve/build the structure needed for a cascading taxonomy.

Testing

none! (counting on previous tests, and the fact I'm adding additional content not structurally different from existing)

Additional context

There is a very minor typo correction unrelated to sports books included here: "Foodplace'delicious foodstuff" was changed to "Foodplace'*s *delicious foodstuff" - an "s" and a space character were added.

Nearly all of the books are based on real books, but with titles changed to protect the innocent. The isbn13 comment indicates what book the imaginary book is based upon.

@Jerimee Jerimee requested a review from I-am-Erk as a code owner May 19, 2020 01:15
@curstwist curstwist added Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON labels May 19, 2020
@Jerimee Jerimee changed the title m WIP books about sports m books about sports May 19, 2020
@Rivet-the-Zombie Rivet-the-Zombie merged commit 3383339 into CleverRaven:master May 21, 2020
@Jerimee Jerimee deleted the sportsbooks branch May 21, 2020 18:39
@Jerimee Jerimee mentioned this pull request May 23, 2020
@ghost ghost mentioned this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants