Add aero-engine #40477
Merged
Add aero-engine #40477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
approved these changes
May 12, 2020
| "copy-from": "engine_gasoline", | ||
| "type": "ENGINE", | ||
| "name": { "str": "light aero-engine" }, | ||
| "description": "An air-cooled, four-cylinder, horizontally opposed internal combustion engine, rated for 150 horsepower. Commonly used on light aircraft.", |
There was a problem hiding this comment.
This looks fine as far as it goes, but is it based on any particular aircraft engine? The Lycoming O-235 used in Cessna 152s is a basically like this, but is 75-100 kW (100-135 HP) depending on the version.
There was a problem hiding this comment.
It's based on Lycoming O-320. I have a Wikipedia link for it in the post above, which says they're either 150 or 160 HP.
There was a problem hiding this comment.
Sorry, I totally missed that. Looks good then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add aero-engine"
Purpose of change
Add an engine which primarily uses avgas (previously only gas turbine engines could use it). In case planes ever get added, they could use this engine.
Describe the solution
Add JSON entries for engine item and vehicle part, abstract definition for aero-engine, and item group entry.
Describe alternatives you've considered
None.
Testing
Built a car with aero-engine, tried fueling it with both gasoline and avgas, drived it around for a bit, crashed into a random APC on the road.
Additional context
I couldn't really find item groups which could spawn an aero-engine, so it's very rare at the moment. Suggestions in this regard are welcome.
Engine is based on Lycoming O-320 engine: https://en.wikipedia.org/wiki/Lycoming_O-320