Update to firearms 45/70 caliber volume and length #40466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimmspector
changed the title
ghost
reviewed
May 12, 2020
Yup! Transcription failure! Co-authored-by: LaVeyanFiend <[email protected]>
curstwist
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Update to firearms 45/70 caliber volume and length"
Purpose of change
Update for longest_length values of 45/70 caliber firearms, following #40232 and updating an in error volume calculation for one gun.
Describe the solution
Update for longest_length on:
1895SBL: 943 mm
BFR: 405 mm
1874 Sharps: 1278 mm
Sharps volume also recalculated without folding sight: 2936 ml
Describe alternatives you've considered
Letting someone else do the work.
Testing
Loaded in game.
Additional context
imgur Images