Add ability for user defined profession names #40447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
[C++]
kevingranade
requested changes
May 12, 2020
|
I have removed the redundant inits and checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add ability for user-defined profession names"
Purpose of change
It has no impact on gameplay other than immersion. After all, we don't want our characters to forever be defined with "tweaker", "naked and afraid", or "lost submissive".
Describe the solution
Instead of this:
we can press * during character display to get a popup below
We can define our characters as this instead:
Deleting the custom profession will reset it back to default functionality.
Describe alternatives you've considered
None.
Testing
Add and remove the custom profession.
Save and reload for save game persistence.