Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flu shot expire #40407

Merged
merged 6 commits into from
May 12, 2020
Merged

Make flu shot expire #40407

merged 6 commits into from
May 12, 2020

Conversation

eJ0opb
Copy link
Contributor

@eJ0opb eJ0opb commented May 10, 2020

Summary

SUMMARY: Bugfixes "Make flu shot expire"

Purpose of change

Prevent the player from stocking on flu shots and taking one every six months. That's not how it works. Nobody is developing vaccines anymore, so there is no vaccine after the last flu season before the cataclysm.

Describe the solution

Check if the current turn is more than 24_weeks after the start of the cataclysm.

Describe alternatives you've considered

  • Leaving it the way it is
  • Figuring out when the last flu season started and using that instead of the start of the cataclysm. That is probably better but I figure this is good enough for now.

Testing

  1. Change the expiration time (in code) to 8_hours + 5_minutes after the start of the cataclysm
  2. Start new game, spawn 2 flu shots
  3. Take flu shot, get vaccinated message, @ screen shows vaccinated
  4. Wait 5 minutes, @ screen no longer shows vaccinated
  5. Take another flu shot, get expired message, @ screen does not show vaccinated

Tacoma ranch:

  1. Start game before changes
  2. Spawn tacoma ranch clinic
  3. Complete missions up to advanced emergency care
  4. Change mission content
  5. Continue missions, you still get the flu shot mission
  6. Start a new game
  7. Spawn tacoma ranch clinic
  8. Complete missions as asked, syringes is after advanced emergency care

Additional context

Logical continuation of #40287

Nobody is developing new vaccines; you can't just stock up on
flu shots and take one every 6 months.
@anothersimulacrum
Copy link
Member

Consider changing the flu shot Tacoma ranch mission to match these changes - if it's not useful after 6 months, perhaps they should be looking for something else.

@ghost
Copy link

ghost commented May 10, 2020

What can the Tacoma Ranch make, then? I'm thinking aspirin or other basic medicine.

@Night-Pryanik
Copy link
Contributor

Maybe add some message mentioning that it won't work after it's expiration date? Maybe for characters with a few of first aid skill levels or MD profession? Otherwise people might be confused on why they get the flu even after applying the vaccine.

@Wishbringer
Copy link
Contributor

Wishbringer commented May 10, 2020

Viruses generally can't survive nor reproduce outside a living compatible host cell.
If "zombies" are considered non-viable hosts then shouldn't normal viruses become increasingly rare, as more time passes, due to plummeting human population density?
Spoiler alert:
To what extent does the XE037 mutagen damage cellular and genetic integrity over time?
Are "Blob" using even our viruses against us? ;(

@anothersimulacrum
Copy link
Member

@Xenomorph-III They aren't making it, they want it for a quest.

@kevingranade
Copy link
Member

Zombies are viable hosts, I want to adjust flu acquisition to be based on exposure to infected zombies instead of pure environmental exposure.

@eJ0opb
Copy link
Contributor Author

eJ0opb commented May 10, 2020

Maybe add some message mentioning that it won't work after it's expiration date? Maybe for characters with a few of first aid skill levels or MD profession? Otherwise people might be confused on why they get the flu even after applying the vaccine.

That's easy enough, but that implies you knew the vaccine didn't work, in which case why would you take the shot in the first place? If anything, I think it's weird that you can positively know that the vaccine worked on you.

@eJ0opb
Copy link
Contributor Author

eJ0opb commented May 10, 2020

Consider changing the flu shot Tacoma ranch mission to match these changes - if it's not useful after 6 months, perhaps they should be looking for something else.

How about just making the mission inaccessible for now? Content addition can go in a separate PR. Players who already have the mission will probably be confused as to how the request for flu shots at some point turned into a request for medical gloves or chicken eggs or whatever they got replaced with.

@Night-Pryanik
Copy link
Contributor

why would you take the shot in the first place?

You could then prevent taking a shot of over-expired vaccine for people with high medical skills.

@wapcaplet
Copy link
Contributor

wapcaplet commented May 10, 2020

That's easy enough, but that implies you knew the vaccine didn't work, in which case why would you take the shot in the first place? If anything, I think it's weird that you can positively know that the vaccine worked on you.

I agree, the "You no longer need to fear the flu" message (and even more so, the visible "vaccinated" status in the @ menu) may be giving too much away, but at least is true and consistent messaging.

The flu shot item description mentions that it's still in the packaging, which suggests it may have a manufacture or expiration date printed on it. Perhaps that idea could be the basis of an alternate message, after "You inject the vaccine", say "You notice the date on the packaging is pretty old, so it may no longer be effective." Then players (especially experienced players who have gotten used to infinite vaccines) won't be confused by the lack of a "vaccinated" indicator.

eJ0opb added 5 commits May 10, 2020 13:27
It doesn't make sense anymore unless this mission is given with
24 weeks of the start of the cataclysm, which is when flu shots
expire.

If you already started this mission chain, you will still get
the mission.
This is for the benefit of experienced players who are used to
unlimited flu vaccines.  More realistic would be to have no
feedback, positive or negative.

Also, update the description, to hint to the player that it will
not work forever.
This reverts commit e511ada.
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Items: Containers Things that hold other things and removed Items: Containers Things that hold other things labels May 11, 2020
@kevingranade kevingranade merged commit 8177d6d into CleverRaven:master May 12, 2020
@Marrim
Copy link
Contributor

Marrim commented May 20, 2020

Shouldn't it still have some reduced effect?
Real-life vaccines are tailored to a particular strain that is expected to be common in next flu season, but the vaccine itself doesn't go bad, it might still help if the strain you caught happens to match.

Or does it actually go bad?

@Profugo-Barbatus
Copy link

Even against the strains vaccines do protect against, their potency wanes with time. Nothing lasts forever.

mlangsdorf added a commit to mlangsdorf/Cataclysm-DDA that referenced this pull request Oct 7, 2020
pr CleverRaven#40407 removed the "fetch a flu shot" (ranch_nurse_mission_10) from
the nurse doc mission sequence.  Unfortunately, starting that mission
triggered the map changes that spawn the Refugee Ranch doctor who can
install CBMs nearly faultlessly.

Clean out the "fetch a flu shot" mission JSON entirely, and add
"start": "ranch_nurse_9" to the next mission's JSON definition, so that
ranch doctor will spawn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants