Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PoolWater to Connects_to and update JSON_INFO #40362

Conversation

sah4001
Copy link
Contributor

@sah4001 sah4001 commented May 8, 2020

Added a new type to connects to and updates the JSON_INFO to show all connects_to tags, added the connects to POOLWATER to the pool tiles.

Summary

SUMMARY: None

Purpose of change

I want to be able to make a pool that has a mix of shallow and deep water and for them to connect.

Describe the solution

Added a new Connects_to type POOLWATER so that they tiles connect properly
Also cleaned up the Connects_to section in JSON_INFO

Describe alternatives you've considered

Making the pool tiles connect to water, but that looks weird and it was not hard to make a new connects_to.

Testing

Built the code and then used the map editor to make sure that the tiles connect properly.

Additional context

When connecting to water.
image
When just connecting to pool tiles
image

sah4001 added 2 commits May 8, 2020 14:01
Added a new type to connects to and updates the JSON_INFO to show all connects_to tags, added the connects to POOLWATER to the pool tiles.
@sah4001
Copy link
Contributor Author

sah4001 commented May 9, 2020

Do I need to fix the profession error Travis is throwing or should I leave them alone?

@anothersimulacrum
Copy link
Member

Nope, not your fault.

@ZhilkinSerg ZhilkinSerg merged commit b317cba into CleverRaven:master May 10, 2020
@sah4001 sah4001 deleted the New-connects_to-types-and-JSON_Info-Update branch May 18, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants