Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create crafting recipes for roller blades and skates #40361

Merged
merged 26 commits into from
May 12, 2020
Merged

Create crafting recipes for roller blades and skates #40361

merged 26 commits into from
May 12, 2020

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented May 8, 2020

Summary

SUMMARY: Content "Crafting recipes for items 'roller blades' and 'roller skates'"

Purpose of change

Allows crafting of roller blades and skates in case of skating emergency, plus recovery of craftable items to make one from the other

Describe the solution

Crafting recipes for roller skates and blades, based on several recipes with similar materials and complexity, especially hard hat for the plastic molding, which is the most complicated piece here. Uncrafting, new skate wheels, and item spawn for the skate wheels

Describe alternatives you've considered

No recipes, more recipes, skateboard, ice skates

Testing

Game loads with no errors, can build the things with the necessary skills, tools, and materials as expected. Uncraft works as expected.
Screen Shot 2020-05-11 at 9 53 24 PM

Additional context

@LyleSY
Copy link
Contributor Author

LyleSY commented May 8, 2020

Inspired by this reddit discussion https://www.reddit.com/r/cataclysmdda/comments/gfs3cj/how_the_hell_does_vormithrax_just_casually_walk/

@anothersimulacrum
Copy link
Member

image
These don't look like they should give normal boots.

@LyleSY
Copy link
Contributor Author

LyleSY commented May 8, 2020

Agreed, I was thinking it would make sense to get damaged boots out of them, but I don't see a way to do that

@LyleSY
Copy link
Contributor Author

LyleSY commented May 8, 2020

...and now I see that the boots in game are all made of leather, not very common for roller blades. Uncrafting might not make a ton of sense here after all.

@LyleSY LyleSY changed the title [WIP] Create uncrafting and crafting recipe for roller blades [WIP] Create crafting recipes for roller blades and skates May 8, 2020
LyleSY added 9 commits May 8, 2020 20:43
Made bearings "ammo" instead of components since they were throwing errors. Customized rollerskates to be more about metal and leather, and a little easier, and roller blades to be about cloth and plastic and a little harder.
Apparently "Using" two different types of ammo crashes the game hard. No thread required for blades now.
Tools: cutting or tools: sewing does not work and kills game start.
Complicated recipes are complicated.
plurals hate us
@LyleSY LyleSY changed the title [WIP] Create crafting recipes for roller blades and skates Create crafting recipes for roller blades and skates May 9, 2020
@LyleSY LyleSY marked this pull request as ready for review May 9, 2020 02:21
@LyleSY LyleSY added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels May 9, 2020
Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the skate frames (the part between the boot and the bearings) to be a custom casting or forging job.
Also you need wheels, there's nothing in the recipe representative of skate wheels.

@LyleSY LyleSY requested a review from kevingranade May 9, 2020 21:00
@LyleSY
Copy link
Contributor Author

LyleSY commented May 10, 2020

I think I've found and murdered all the bugs now, that Travis error looks like it's about nested containers

Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are still way too approximate, especially with as OP as the game makes these things.

data/json/recipes/armor/feet.json Outdated Show resolved Hide resolved
data/json/recipes/armor/feet.json Outdated Show resolved Hide resolved
data/json/recipes/armor/feet.json Outdated Show resolved Hide resolved
data/json/uncraft/armor/boots.json Outdated Show resolved Hide resolved
LyleSY added 3 commits May 11, 2020 12:03
Standardized skate recipes to use smithing and swaging instead of welding, take longer, and only use pipe and scrap instead of aluminum.
@LyleSY
Copy link
Contributor Author

LyleSY commented May 11, 2020

These are still way too approximate, especially with as OP as the game makes these things.

Can you give me an example of what you have in mind here? I'm looking at end game weapons like katana and zweihander and this is much richer. Katana example:
"type": "recipe", "result": "katana", "category": "CC_WEAPON", "subcategory": "CSC_WEAPON_CUTTING", "skill_used": "fabrication", "difficulty": 9, "time": "8 h", "book_learn": [ [ "textbook_weapeast", 8 ] ], "using": [ [ "blacksmithing_standard", 8 ], [ "steel_standard", 2 ] ], "qualities": [ { "id": "CHISEL", "level": 3 } ], "tools": [ [ [ "swage", -1 ] ] ], "components": [ [ [ "2x4", 2 ], [ "stick", 4 ] ], [ [ "fur", 2 ], [ "leather", 2 ] ] ]

Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shifting everything over to blacksmithing does it.

@kevingranade kevingranade merged commit 8907353 into CleverRaven:master May 12, 2020
@LyleSY LyleSY deleted the patch-1 branch May 12, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants