Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement requirement for manual install of CBMs #40360

Merged
merged 7 commits into from
May 12, 2020

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented May 8, 2020

Summary

SUMMARY: Infrastructure "Implement installation requirment for CBMs"

Purpose of change

You can now specify a requirement_id to set the tools and components necessary to manualy install a CBM

Describe the solution

Add requirement_id entry to bionic_data
Check for requirement when activating a CBM
No requirement means manual install is not possible
If the player has the tool and components consume them and porceed with the installation

Describe alternatives you've considered

Testing

Give sewing_standard to finger laser cbm
Get a sewing tool and thread
Try to install
Get popup about missing cutting quality
Get a knife an retry
Popup about missing anesthetic
Get anesthesia kit and retry
Porceed with instalation and get a faulty install
Anesthetic was consumed
A thread was consumed

Test that tacoma doctor still works with or without requirement

Additional context

@Night-Pryanik
Copy link
Contributor

We've done such a large work to get rid of manual installation of CBMs, and now we're returning back?

@Fris0uman
Copy link
Contributor Author

This system can be defined per CBM instead of the all or nothing we had before, also I don't really plan on making any current vanilla CBM installable manually, but maybe aftershock could use this and it could also be the basis for having NPCs performing surgery on the player.

@Rail-Runner
Copy link
Contributor

Rail-Runner commented May 8, 2020

Could we get the same thing for CBM removal and skills used for either? I think it could be particularly useful for mods adding CBMs that are not actually bionics and rather some other kind of permanent non-random body modification.

@Fris0uman
Copy link
Contributor Author

There's no support in place for manual uninstallation and I'm not interested in adding it.

@Fris0uman Fris0uman marked this pull request as ready for review May 8, 2020 21:11
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON labels May 11, 2020
src/bionics.cpp Outdated Show resolved Hide resolved
src/bionics.h Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 1c77a12 into CleverRaven:master May 12, 2020
@Fris0uman Fris0uman deleted the manual branch May 12, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants