Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "TARGET" category to some keybindings #40348

Merged
merged 3 commits into from
May 9, 2020
Merged

Add "TARGET" category to some keybindings #40348

merged 3 commits into from
May 9, 2020

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented May 8, 2020

Summary

SUMMARY: None

Purpose of change

None of the keybindings in data/raw/keybindings.json have TARGET category yet some of them are used only in target ui.

Describe the solution

Add TARGET category to these keybindings.

Testing

Searched the repo for each changed keybinding, found no usages outside target ui. Opened target ui, opened ? screen - the keys are there, but now marked as non-global. Left the ? menu, pressed some of the keys - still works as intended.

@enaantd
Copy link
Contributor

enaantd commented May 8, 2020

just a question: why is the F keybinding changing from "fire" to "switch firing mode"?

@olanti-p
Copy link
Contributor Author

olanti-p commented May 8, 2020

Normally, you wield a gun and press F to change attack mode - e.g. cycle between auto, semi-auto and a bayonet, or select favorite ammo for bows.

{
"type": "keybinding",
"name": "Toggle attack mode of Wielded Item",
"category": "DEFAULTMODE",
"id": "select_fire_mode",
"bindings": [ { "input_method": "keyboard", "key": "F" } ]
},

I feel this key should do the same thing in target ui. There is already a key for ammo selection though, so it should just change attack mode.

@ZhilkinSerg ZhilkinSerg merged commit 442916a into CleverRaven:master May 9, 2020
@olanti-p olanti-p deleted the target-input-context branch May 9, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants