Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead mods: Tankmod #40334

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Remove obsolete mods. I figure it's been long enough that old saves won't be a problem, but I could be wrong.

Describe the solution

git rm -r obsolete mods

Describe alternatives you've considered

Waiting longer.
Adding the mods removed to the mod test blacklist. I decided against this to prevent merge conflicts, it can be done later.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Organization General development organization issues labels May 8, 2020
@ave-
Copy link
Contributor

ave- commented May 8, 2020

@Soup-de-Loop moved treads from blazemod to this mod in #40067, is it really obsolete now?

@Wishbringer
Copy link
Contributor

Wishbringer commented May 8, 2020

Also #40067 fixed turret mounts in Tanks mod, so even though it's marked as obsolete I believe it to be functional now.

@Soup-de-Loop
Copy link
Contributor

It is obsolete but in its current implementation still outdated. The fix was a going-forward sort of once off-thing for legacy users. I'll host a snapshot of it on my repo, but it can be considered properly terminated as a mainline inclusion because the implementation is hacky and not particularly plausible, both in how the vehicle parts operate and the prevalence of relatively undamaged and usable military vehicles strewn all over the place.

There is interest in providing true continuous track support at some point on vehicles, at most right now it's a task of collecting enough data to be able to draw conclusions from which to model.

I'll be trying to make a similar-but-different idea stemming from it, as short single-section continuous tracks such as those featured in half-track vehicles and small earth movers as a first-step in gathering data and basic implementation investigation.

@kevingranade kevingranade merged commit 54e575f into CleverRaven:master May 8, 2020
@anothersimulacrum anothersimulacrum deleted the rm-mod7 branch May 8, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Organization General development organization issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants