Add test spells (json) and spell tests (cpp) #40328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wapcaplet
force-pushed
the
spelling-bee
branch
2 times, most recently
from
75ddef9 to
a9a23c9
Compare
KorGgenT
reviewed
May 8, 2020
KorGgenT
reviewed
May 8, 2020
|
damage over time is also a member of spells, and pretty new at that |
Ha, I had momentarily stubbed in a |
Test spell functions and effects with fake spells in the `TEST_DATA` mod. Exercises these functions: - spell class: - name - exp_to_next_level - get_level, set_level - damage, range, aoe - duration_string - cast_spell_effect - spell_effect class: - target_attack - spawn_summoned_monster - recover_energy Related JSON data: - name, max_level - min_damage, max_damage, damage_increment - min_duration, max_duration, duration_increment - min_range, max_range, range_increment - min_aoe, max_aoe, aoe_increment - effect, effect_str - base_energy_cost, energy_source Also fixes a potential infinite loop in spell::gain_levels when attempting to reach the maximum spell level. Co-authored-by: Curtis Merrill <[email protected]>
wapcaplet
changed the title
ZhilkinSerg
added
Code: Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add tests for magic spells"
Purpose of change
Getting a start on spell tests to help support Magiclysm
Describe the solution
Adds test spells to the
TEST_DATAmod, and some test cases using them to verify behaviors of spell-related functions.Currently exercises these functions:
JSON data covered:
Also includes a fix to the
gain_levelsspell that was causing an infinite loop when trying to reach the maximum level.Describe alternatives you've considered
Eternal shadow
There are many more effects that are not yet tested, but this should lay the groundwork.
Testing
tests/cata_test [magic]Additional context
Reference: doc/MAGIC.md