Eat crash hotfix #40323
Merged
Eat crash hotfix #40323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
<Crash / Freeze>
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
This is a hotfix related to the crash in #40268 but it does not fix the underlying issue.
Describe the solution
I added a debug message in the finish function for consumption when the item_location has lost its pointer, which returns early and cancels the activity. This makes the game no longer seg fault, but you still cannot eat an item via the inventory screen. I couldn't figure out exactly why the activity loses track of the item_location.
Describe alternatives you've considered
Testing
A debug message and bailing out of the activity is significantly better than a crash imo.
Additional context