Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun volume audit for 7.62x39 #40263

Merged
merged 3 commits into from May 11, 2020
Merged

Gun volume audit for 7.62x39 #40263

merged 3 commits into from May 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2020

Summary

SUMMARY: Content "Realistic gun volumes for 7.62x39"

Purpose of change

Helps #37374.

Describe the solution

Adjusted volumes, added longest_side based on Feret diameter.

Describe alternatives you've considered

None.

Testing

Loading ingame with #40186 active.

Additional context

Requires #40186.

Beretta ARX-160, OAL 90.8cm/weight 3.08kg/width 7.0cm(using semi-auto version, same weight & barrel length): https://www.beretta.com/en-us/arx-100/#FeaturePoint_1
Removing magazine: https://imgur.com/a/QYLNN0G
SA+Feret: https://imgur.com/a/OMrtlOW

SKS, OAL 102cm: http://pdf.textfiles.com/manuals/MILITARY/united_states_army_tc_9-56%20-%201_october_1969.pdf
Pictures for SA/Feret/Width: https://www.americanrifleman.org/articles/2017/2/7/exploded-view-sks-carbine/
SA + Feret for both the rifle & spike bayonet: https://imgur.com/a/2B9HCwn
Measuring buttplate height to get width: https://imgur.com/a/aKA0jJU
Rifle width after scaling to buttplate height: https://imgur.com/a/NnqoIJ7
Bayonet width after scaling to buttplate height: https://imgur.com/a/haFgSA4

AKs & Draco were audited in #39041, but their volumes were set based on a miscommunication on my part over which source I was using. Just swapped to the volumes based on the work drawing provided by carmakazi.

Feret for AK: https://imgur.com/a/9Uh6uo4
Feret for Draco: https://imgur.com/a/oGp7r53

@mlangsdorf mlangsdorf added Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels May 7, 2020
@ghost ghost changed the title Gun volume audit for 7.62x39 x54 Gun volume audit for 7.62x39 and x54 May 10, 2020
@ghost ghost changed the title Gun volume audit for 7.62x39 and x54 Gun volume audit for 7.62x39 May 10, 2020
@ghost ghost changed the title Gun volume audit for 7.62x39 [Needs Testing] Gun volume audit for 7.62x39 May 10, 2020
@ghost
Copy link
Author

ghost commented May 10, 2020

image
image
image
image
From testing.

@ghost ghost marked this pull request as ready for review May 10, 2020 20:03
@ghost ghost changed the title [Needs Testing] Gun volume audit for 7.62x39 Gun volume audit for 7.62x39 May 10, 2020
@kevingranade kevingranade merged commit a0cc190 into CleverRaven:master May 11, 2020
@ghost ghost deleted the GunVolumes762x39 branch May 11, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants