move item contents info to bottom of iteminfo screen #40260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
Info / User Interface
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
If an item has a lot of contents, it really clogs up the info screen because it shows the name and description of each item. So i moved the full list of contents to the bottom - I did not delete this because this also shows contents of magazines, which do not show as pockets in the item info screen as of now.
Describe alternatives you've considered
Leave it there
Testing
started the game, looked at an item with a bunch of stuff in it
Additional context
This PR is mostly due to some complaints i've heard from players - and I agree with them. It will also be worth coming in later and condensing some of the pocket contents data to show multiple items of the same type in one line.