Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refridgerated Tank Fix #40235

Merged
merged 7 commits into from
Jul 26, 2020

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented May 6, 2020

Summary

SUMMARY: Bugfixes "Refridgerated Tank Fix"

Purpose of change

Contributes to #39546. I've got it working as a tank. I've got it working as an electronic. It may be refrigerating the spoilable milk. I don't know because while it takes almost two days to rot in the vehicle menu, it a. never shows as cold, b. comes out fresh at least two days after putting it in when it's siphoned out and finally c. all contents disappear from the tank the second you take a single step, you can wait forever but if you debug change the time or walk a step everything inside vanishes.

Describe the solution

Witchcraft. Flag witchcraft. I've looked at the src and can't see any reason that it's acting weird but I speak C++ like I speak most languages. I know a word or two and with a lot of diagrams I can maybe understand a sentence.

Describe alternatives you've considered

Waking Cthulhu.

Testing

Tests are basically described up top. I spawn in stuff I install I wait.

Additional context

@RedShakespeare
Copy link
Contributor

It may help to put a jug of milk aside as a reference when testing..?

@Maleclypse
Copy link
Member Author

@anothersimulacrum do you have any ideas as to why these two flags are not interacting in the ways that it seems they should know that pockets work?

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON labels May 29, 2020
@Maleclypse Maleclypse changed the title WIP Refridgerated Tank Fix Refridgerated Tank Fix Jul 22, 2020
data/json/vehicleparts/tanks.json Outdated Show resolved Hide resolved
data/json/items/vehicle/utilities.json Outdated Show resolved Hide resolved
Maleclypse and others added 2 commits July 24, 2020 14:51
@kevingranade kevingranade merged commit d88c69f into CleverRaven:master Jul 26, 2020
@Maleclypse Maleclypse deleted the refrigerated-tank-fix branch May 27, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants