-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refridgerated Tank Fix #40235
Merged
kevingranade
merged 7 commits into
CleverRaven:master
from
Maleclypse:refrigerated-tank-fix
Jul 26, 2020
Merged
Refridgerated Tank Fix #40235
kevingranade
merged 7 commits into
CleverRaven:master
from
Maleclypse:refrigerated-tank-fix
Jul 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may help to put a jug of milk aside as a reference when testing..? |
This was referenced May 10, 2020
@anothersimulacrum do you have any ideas as to why these two flags are not interacting in the ways that it seems they should know that pockets work? |
anothersimulacrum
added
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
labels
May 29, 2020
Co-authored-by: anothersimulacrum <[email protected]>
Co-authored-by: anothersimulacrum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Refridgerated Tank Fix"
Purpose of change
Contributes to #39546. I've got it working as a tank. I've got it working as an electronic. It may be refrigerating the spoilable milk. I don't know because while it takes almost two days to rot in the vehicle menu, it a. never shows as cold, b. comes out fresh at least two days after putting it in when it's siphoned out and finally c. all contents disappear from the tank the second you take a single step, you can wait forever but if you debug change the time or walk a step everything inside vanishes.
Describe the solution
Witchcraft. Flag witchcraft. I've looked at the src and can't see any reason that it's acting weird but I speak C++ like I speak most languages. I know a word or two and with a lot of diagrams I can maybe understand a sentence.
Describe alternatives you've considered
Waking Cthulhu.
Testing
Tests are basically described up top. I spawn in stuff I install I wait.
Additional context