Add creature effect tests #40234
Merged
Add creature effect tests #40234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes test cases for `Creature` effects, covering functions: - add_effect, remove_effect - has_effect, has_effect_with_flag - resists_effect, is_immune_effect Behaviors exercised: - characters may have an effect on a body part, or all-body - monsters may only have all-body effects (not having body parts) - monsters immune to an effect can still be forced to have it - fleshy, warm-blooded monsters can bleed and be poisoned - bony, non-warm monsters are immune to bleeding and poison - fleshy, non-warm-blooded monsters are immune to bleeding and poison - Slimy mutation gives immunity to corroding effect - Tentacle bracing mutation gives immunity to downing - Strong Stomach mutation gives immunity to nausea
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add tests for creature effect functions"
Purpose of change
To have some test coverage of effects on creatures (monsters and characters).
Describe the solution
Includes test cases for
Creatureeffects, covering functions:Behaviors exercised:
Describe alternatives you've considered
Faking it all with latex and lighting
Testing
tests/cata_test [effect][creature]Additional context
There is more work to be done here, but I am leaving a few TODOs undone to leave an opening for future contributors.
Part 2 of splitting #40064