Fix target UI regressions caused by #39785 #40221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
<Bugfix>
|
If you feel inspired to do more, these seem like some excellent things to have unit tests for. |
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #40215
Fixes #40176
Fixes #40243
Describe the solution
Add missing check for spell damage; allow aiming at yourself with spells that consider
target_selfa valid target; properly select between square/circle distancesDescribe alternatives you've considered
Not making bugs is a good alternative I guess
Testing
Casted
Blesson myself, receivedBlessed (torso).Spawned an NPC, tried to cast
Blesson them - nothing happened (not an ally).Befriended them and tried to casted
Blessonce again - succeeded. NPC did not become angry, checked NPC's status - the haveBlessed (torso).Tried to cast
Cone of Coldon myself - nothing happened (not a valid target).Casted
Cone of Coldon NPC - they got hurt and became angry.Tried to use steel spear to attack an NPC across a 1-tile diagonal gap - can't reach (range 3 with circular distances). Disabled circular distances, tried again - success.