Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "adds a bulk shipping crate possibility to the supplydrop map extra"
Purpose of change
Provides a supply crate with a bulk package of a one item. So, for example, you get 128 units of dental floss or 32 voltmeters.
Describe the solution
Two lines were added to map_extras.cpp with the intended effect of making mil_food return only 30% of the time (down from 40%) and mil_bulk return 1 in 10.
mil_bulk:
Or, simplified, mil_bulk is a 1d7 roll on this table:
Describe alternatives you've considered
I wanted to this bulk crate to contain only one type of item, but as it stands now it will be paired with another item from the mx_supplydrop switch. There is 1 in 100 chance that a crate will contain two bulk items. It would be better if case 1 (mil_bulk) meant that only one item was generated. I think this could be achieved by putting
int items_created = 0;
inside the switch, and then setting case 1 toint items_created = 1;
but didn't want to muck too much up.The diversity of possible items in mil_bulk could be increased.
The bulk items could each be placed in boxes or together in some sort of cellophane warehouse packaging to simulate a shipping container (packing peanuts?).
Additional context
I believe there is no way for this item group to use existing item groups in order to get a better diversity of items. Because 32 instances of an item group will not return 32 instances of one item, but instead a variety of items from that group.