implement pocket max item size #40214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
<Enhancement / Feature>
KorGgenT
force-pushed
the
max-item-size-in-pocket
branch
from
de34675 to
f8f68f9
Compare
KorGgenT
force-pushed
the
max-item-size-in-pocket
branch
from
f8f68f9 to
e0e975b
Compare
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "implement pocket max item size"Purpose of change
We needed a few more attributes to limit items that can be placed in other items. This and length i think should cover the vast majority of situations.
Describe the solution
add a new member to pocket_data, read it, add it to item_pocket:;can_contain and item_pocket::info functions to make them usable.
Describe alternatives you've considered
aperture size and adding dimension values to every item
Testing
edited a 2 liter bottle to have this new member, based on having a 1" opening and doing a simple calculation. spawned one in, and tried to pick up things. they asked me to wield them instead.
Additional context