Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give protein bar it's own wrapper #40210

Merged
merged 3 commits into from
May 15, 2020

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented May 5, 2020

Summary

SUMMARY: Content "give protein bar its own branded wrapper"

Purpose of change

This minor PR make a new paper wrapper and associate it with protein_bar_evac. The wrapper is sized to fit protein_bar_evac.

Describe the solution

  • protein_bar_evac is 150 g and 223 ml, so the wrapper is max_contains_volume": "225 ml", "max_contains_weight": "1 kg"
  • the branded wrapper is 9 lines long in containers.json, and then just change protein_bar_evac to have the new container
  • the wrapper has this description: "DaiZoom Protein Bar, brought to you by SoyPelusa" is emblazoned proudly upon this greaseproof wrapper.

Describe alternatives you've considered

I like items to have branding associated with them, but of course then you have to make up names. Clearly the name of this bar could be something else; I choose it as a sort of pun on what google said was the Japanese word for soy: "Daizu."

So I called it DaiZoom. Other names I considered:

  • Nutri-Beyond
  • PROvision
  • Protein Pow!
  • Bar Supreme
  • Powersauce (from the Simpsons)

Clutter content might distract/confuse players. I'm thinking this wrapper is slightly less confusing than before, but clearly this content is simply for clutter/world-building.

I wanted the wrapper to have name DaiZoom wrapper, but that made the protein bars looks weird: "2 DaiZoom wrappers of protein bar" or "2 protein bar wrappers of protein bar" - so I just used simple "wrapper" to make it not confusing for new players.

Testing

I loaded the game, no bugs, and saw I was able to unload and eat (or just eat) the bar in the normal way.

Additional context

It used to be (still is maybe?) that a paper wrapper of protein bar had a parenthetic expression "(1/11)" next to it. As a new player this confused/bugged me - why are all the protein bars 91% empty. Did someone already eat most of each bar? I tried stuff like reloading the bar wrappers or looking at the stats to determine what "1/11" signified; it made me feel like I was missing something relevant that the game was clearly trying to inform me of.

I think the new containers features will make this trivial issue irrelevant anyway, but I didn't see any reason not to add the clutter content to scratch my own itch.

@ghost
Copy link

ghost commented May 5, 2020

It used to be (still is maybe?) that a paper wrapper of protein bar had a parenthetic expression "(1/11)" next to it. As a new player this confused/bugged me - why are all the protein bars 91% empty. Did someone already eat most of each bar? I tried stuff like reloading the bar wrappers or looking at the stats to determine what "1/11" signified; it made me feel like I was missing something relevant that the game was clearly trying to inform me of.

I was wondering that too, now you tell me. I thought the wrapper was capable of holding 11 protein bars, but there was only 1 in the wrapper. Which is odd - most protein bars are wrapped individually in the shops:

download

@KorGgenT
Copy link
Member

KorGgenT commented May 6, 2020

Nutri-Beyond
PROvision
Protein Pow!
Bar Supreme

You can add all of these to snippets, and i think that would be great.

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels May 6, 2020
@Jerimee
Copy link
Contributor Author

Jerimee commented May 6, 2020

Nutri-Beyond
PROvision
Protein Pow!
Bar Supreme

You can add all of these to snippets, and i think that would be great.

But wouldn't that break the SoyPelusa kickstarter lore? Like wouldn't SoyPelusa just want one brand identity?

@KorGgenT
Copy link
Member

KorGgenT commented May 6, 2020

oh, i don't know lore-wise, i just thought having multiple punny snippets for protein bars would be fun

m
hoping Travis is in a better mood today
@kevingranade kevingranade merged commit 57b3b55 into CleverRaven:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants