Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make character::has_artifact_with non virtual #40181

Closed
wants to merge 1 commit into from

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

LGTM.com is reporting a warning about an invocation of Character::has_artifact_with() from the player constructor since it's a virtual function.

Describe the solution

Silence the warning by making has_artifact_with non-virtual, it is not overridden in any subclasses anyway and there is no reason to do so.

Describe alternatives you've considered

This call could occur in an init method instead.

Testing

The alert is not a sign of a valid issue, as there is only one definition of the function so it is the one invoked. As such there should be no change to the operation of the code.

@kevingranade
Copy link
Member Author

My search missed an override derp.

@kevingranade kevingranade deleted the kevingranade-actual-has-artifact-with branch May 21, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant