Move more body_part to bodypart_id #40138
Conversation
|
IDK if it's a false negative, but this is triggering an issue in the behavior test. |
|
I also got an immediate crash on loading a game, so I'm going with that being a real problem :D |
mlangsdorf
added
Mechanics: Character / Player
src/character.cpp
Outdated
| temp_equalizer( bodypart_id( "torso" ), bodypart_id( "leg_r" ) ); | ||
| temp_equalizer( bodypart_id( "torso" ), bodypart_id( "head" ) ); | ||
| } | ||
| if( bp == bodypart_id( "head" ) ) { |
There was a problem hiding this comment.
it's a little ugly, but this should probably be a series of else if statements for a mild improvement in performance.
I'm not sure if it's worth predeclaring the bodypart_ids as consts.
Ideally, all this would go away and be replaced by lists of bodypart_ids to be equalized attached to each bodypart_id, but that's obviously beyond the scope of this PR.
There was a problem hiding this comment.
An alternate intermediate solution would be to have e.g. a hardcoded unordered_map<bodypart_id, vector<bodypart_id>>. That might lead to cleaner code, but I don't think it matters that much.
Plus post-cherrypick fixes
Summary
SUMMARY: Infrastructure "Move more body_part to bodypart_id in temperature related functions"
Purpose of change
Part of #39068
Describe the solution
Describe alternatives you've considered
Testing
Compile without error
Additional context