Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #39914 (Random error) #40098

Merged
merged 1 commit into from
May 3, 2020
Merged

Fix #39914 (Random error) #40098

merged 1 commit into from
May 3, 2020

Conversation

BevapDin
Copy link
Contributor

@BevapDin BevapDin commented May 3, 2020

SUMMARY: None

After encountering this myself (in hindsight it's probably caused by a corpse being revived and subsequently being removed, the item in question was a corpse). The relevant information from gdb:

(gdb) print removed_items.front()
$11 = (item *) 0x1b0df490
(gdb) print this
$12 = (item * const) 0x1b0df490

Note that the games effectively calls this->remove_item(this), which can not work.

item::visit_items invokes the given callback for this as well, and therefor this appears in the list of item to be removed at the end.

Fixes #39914, I suspect it also fixes #39402 as it has the same backtrace (item::process calling visitable::remove_item).

@BevapDin
Prevent attempt to removing an item from itself.
1ed056b 
The code calls `visitable::visit_items` and adds all items to be removed as reported by the lambda to the vector and later calls `visitable::remove_item` for all those listed items. But `visit_items` will visit `this` as well. So the vector ends up containing `this`, which is subsequently given to `remove_item`, which complains (correctly) that `this` is not contains in `this`.
@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels May 3, 2020
ifreund
ifreund approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ifreund ifreund merged commit 3f4e86a into CleverRaven:master May 3, 2020
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/experimental-bugs-tried-removing-item-from-object-which-did-not-contain-it/23447/13

fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request May 3, 2020
@fengjixuchui
Merge pull request #161 from CleverRaven/master
f59c6ae 
Merge pull request CleverRaven#40098 from BevapDin/uoy
@olanti-p olanti-p mentioned this pull request May 3, 2020
Closed
@Termineitor244
Copy link
Contributor

Thanks for this! Indeed, it was mainly a problem with zombie corpses reanimating.

@BevapDin BevapDin deleted the uoy branch May 7, 2020 16:16
This was referenced May 10, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifreund ifreund ifreund approved these changes

Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
4 participants
@BevapDin @kevingranade @Termineitor244 @ifreund