Fixes 100% chances to trigger teleglow effects #39895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust chances to be consistent with those in old versions.
Add "one_in chance>0" assertion.
Delete "="
|
Would probably be better to use 6_seconds instead of 6_turns. |
Replaced 6_turns with 6_seconds
Indeed. wwww |
KorGgenT
reviewed
Apr 25, 2020
KorGgenT
reviewed
Apr 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes 100% chances to trigger teleglow effects"Purpose of change
Fixes #39894.
Describe the solution
Change the outdated
1_turnsinto6_turnsand add "chance>=0" assertion to rng.cpp.Describe alternatives you've considered
Adjust the
turnsdefinition.Testing
Repeat the "Reproduce Steps" of #39894 and you'll see much less messages about "bright lights"
Additional context