Tweak in hopes of fixing clang build #39885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line of code fell afoul of the oft-troublesome clang error "default initialization of an object of const type without a user-provided default constructor". Attempt to fix that.
|
Looks like it fixed the build, but there are a bunch of DPS test failures. I'm assuming they're unrelated. |
ifreund
approved these changes
Apr 25, 2020
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Apr 25, 2020
Merge pull request CleverRaven#39885 from jbytheway/fix_clang_build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fix broken CI caused by #39873.
Describe the solution
This line of code fell afoul of the oft-troublesome clang error "default initialization of an object of const type without a user-provided default constructor". Attempt to fix that.
Testing
I don't have an old enough clang version to reproduce the error, so testing it here on CI.