Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazemod Mini-PR: Further refactor blaze vehicle parts #39756

Merged

Conversation

Soup-de-Loop
Copy link
Contributor

Summary

SUMMARY: Mods "Further refactor blaze vehicle parts"

Purpose of change

This is the seventeenth PR in bringing the changes in #37497 about, by breaking each change into small parts that are easier to skim and understand.

Describe the solution

Adopt closer standardisation of file structure to vanilla/mainline by moving engines into their own file.

Testing

Straightforward changes drawn from #37497, probably might work for now but its compatibility will be broken again when ID's are changed.

Additional context

More PR's to come, consider incomplete by itself, part of a whole.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions labels Apr 20, 2020
adopt closer standardisation of file structure to vanilla/mainline by moving engines into their own file
@Soup-de-Loop Soup-de-Loop force-pushed the soupdeloop-blazemod-PR17 branch from 2a15ef0 to c28536b Compare April 20, 2020 23:59
@Soup-de-Loop
Copy link
Contributor Author

Sorry about any issues that might've arisen from this one, I rebased it to resolve conflicts. Should've realised that one of these should've stayed as a draft until the other went through, since they touch the same file. My bad, Zhilkin.

@ZhilkinSerg ZhilkinSerg merged commit 8f50e88 into CleverRaven:master Apr 21, 2020
@Soup-de-Loop Soup-de-Loop deleted the soupdeloop-blazemod-PR17 branch April 30, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants