Fix crash when refreshing new character menu while the filtered list is empty #39400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix crash when refreshing new character menu while the filtered list is empty"
Purpose of change
When filtering the profession or scenario list in new character menu, if no match is found, a "no result" popup will show up. While an indexing error would not happen before migrating the menu to
ui_adaptor, after migration it's possible to trigger redraw of the menu when the list is empty, for example while the "no result" popup is being displayed, and cause an index-out-of-bounds error.Describe the solution
Do not display profession or scenario data when the selected index is out of bounds.
Testing
Filtered profession / scenario lists in new character menu, and resized the game window when the "no result" popup showed up. Profession and scenario data were not redrawn. This should fix the crash, but I cannot test it because my build didn't crash before the fix either.