Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user defined height and age #39385

Merged

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Apr 8, 2020

Summary

SUMMARY: Features "User defined height and age"

Purpose of change

I felt like height and age were extremely simple attributes that will help roleplaying and immersion, so I made them possible to define in character creation. I limited age to 16-55 and i limited height to 145-200 cm. the second is just about 2 std deviations from average, the bottom number is 2 std deviations below female average height, and the top number is 2 std deviations above male average height.

Testing

  1. loaded a character that was made before these changes. it loads the default values of 25 years and 175 cm.
  2. created a new character with min age and min height. then added the unassuming trait, bringing my height down to 4'1" (very very short, but i sort of expected it to be smaller)
  3. created a new character with max age and max height. then added the freakishly huge trait, bringing my height to 9'0" (freakishly huge indeed!)

Additional context

You know, maybe the mutations can adjust the height directly instead of size? and you get size from height and weight? idk, it's out of scope of this pr but worth mentioning. I will add screenshots later.

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Mechanics: Character / Player Character / Player mechanics labels Apr 8, 2020
@anothersimulacrum
Copy link
Member

Could I suggest adding a way to randomize these within the new character menu?

@KorGgenT
Copy link
Member Author

KorGgenT commented Apr 9, 2020

is there already a randomize button somewhere? something i need to hook into?

@anothersimulacrum
Copy link
Member

You'd probably want to do it for random new characters too, in avatar::randomize. As for player chosen randomization, there is already * for randomize name.

@KorGgenT
Copy link
Member Author

KorGgenT commented Apr 9, 2020

image
added it to avatar::randomize(). i don't think it's appropriate to randomize age and height when randomizing the name on the custom create.

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Apr 9, 2020

No, I'm asking for a separate keybindings for randomizing those.

@cupnooodle
Copy link
Contributor

Perhaps the height attrib could be also be used to determine good/poor fit in clothing.

@kevingranade kevingranade merged commit 023e222 into CleverRaven:master Apr 9, 2020
@KorGgenT KorGgenT deleted the user-defined-height-and-age branch April 9, 2020 09:48
@KorGgenT
Copy link
Member Author

KorGgenT commented Apr 9, 2020

@anothersimulacrum looks like we'll need another pr for such a thing. ditto for @cupnooodle

@Tairesh
Copy link
Contributor

Tairesh commented Feb 1, 2022

Why is the maximum age limited to 55? I understood that for some ethic and legal reasons in some countries the minimum is limited to 16, but why we can't play with 60yo character?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants