Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move concrete related recipes from autolearn to book #39384

Merged
merged 13 commits into from
Apr 10, 2020

Conversation

SkuliAdams
Copy link
Contributor

@SkuliAdams SkuliAdams commented Apr 8, 2020

Summary

SUMMARY: Content "Adds 'Concrete Constructions' book to hold concrete related recipes"

Purpose of change

Contributes to #37122

Currently, recipes for concrete and related items (mortar, cement, and quicklime) are autolearned at a sufficient level of fabrication. This PR moves those recipes to a book.

Describe the solution

  • Disabled autolearn for relevant recipes
  • Added '''concrete_book''' item with recipes
  • Added book to '''textbooks_school''' and '''hardware_books''' item groups
  • Added quicklime recipe to '''textbook_chemistry''' and '''adv_chemistry'''

Describe alternatives you've considered

I considered leaving the quicklime recipe to be autolearned, given its other uses, but decided to add its recipe to chemistry textbooks so you don't need a book about concrete to make acetylene.

Testing

  • Spawned a new character and raised fabrication to 10, confirmed recipes not known
  • Tested relevant item groups and confirmed book spawn
  • Visited a library and found the book there
  • Spawned book, confirmed it contained correct recipes
  • Spawned the chemistry textbooks to confirm they contain quicklime recipe

Additional context

This is my first contribution, so please let me know if you have any tips or suggestions, especially regarding item spawn frequency.

@SkuliAdams SkuliAdams requested a review from I-am-Erk as a code owner April 8, 2020 23:13
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Apr 9, 2020
@kevingranade kevingranade merged commit 1de418f into CleverRaven:master Apr 10, 2020
@SkuliAdams SkuliAdams deleted the concrete branch April 10, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants