Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll inventory item info by page instead by line #39380

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Apr 8, 2020

Summary

SUMMARY: Interface "Faster scrolling of inventory item information"

Purpose of change

For an item that has a lot of information in the panel the scrolling takes several seconds as it scrolls 1 line per (whatever is unit of time for UI refresh?). This changes so one press of page up/down scrolls that information panel by a page.

Describe the solution

Calculate the page height and add/substract that instead of ++/--.

Doesn't look like scroll position needs clamping - seems it's handled as selection and clamped somewhere inside the menu routines.

Testing

Open an item with a long description, scroll down, then up, checked scrolling works as intended, repeat for short.

Additional context

Before and after; before moves down by 1 line, after by 1 page
image

@JeanLucVanDamme
Copy link

Nice, this is a much better default IMO.

But why not have both? Arrows up/down to scroll by line, page up/down (or whatever the binding in item info screen) to scroll by page. Like any other document.

@irwiss
Copy link
Contributor Author

irwiss commented Apr 9, 2020

@JeanLucVanDamme
image

Pg up/down controls the left description panel, the arrow keys already control the menu on the right

@irwiss irwiss force-pushed the item-info-ui-scroll-by-page branch from 6477d1a to 079de98 Compare April 9, 2020 16:55
@kevingranade kevingranade merged commit 7ce0761 into CleverRaven:master Apr 11, 2020
@irwiss irwiss deleted the item-info-ui-scroll-by-page branch April 14, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants