Scroll inventory item info by page instead by line #39380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Faster scrolling of inventory item information"
Purpose of change
For an item that has a lot of information in the panel the scrolling takes several seconds as it scrolls 1 line per (whatever is unit of time for UI refresh?). This changes so one press of page up/down scrolls that information panel by a page.
Describe the solution
Calculate the page height and add/substract that instead of ++/--.
Doesn't look like scroll position needs clamping - seems it's handled as selection and clamped somewhere inside the menu routines.
Testing
Open an item with a long description, scroll down, then up, checked scrolling works as intended, repeat for short.
Additional context
Before and after; before moves down by 1 line, after by 1 page