Run IWYU 20200408 #39364
Merged
Run IWYU 20200408 #39364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pragma got accidentally removed because it was deemed to be a comment attached to a #include.
ZhilkinSerg
added
[C++]
ZhilkinSerg
reviewed
Apr 8, 2020
ZhilkinSerg
reviewed
Apr 8, 2020
ZhilkinSerg
reviewed
Apr 8, 2020
ZhilkinSerg
reviewed
Apr 8, 2020
|
Thanks. Fixed that manually for now, but that looks like yet another IWYU bug I might have to look at at some point (probably one I introduced, this time...). |
ZhilkinSerg
reviewed
Apr 9, 2020
ZhilkinSerg
reviewed
Apr 9, 2020
ZhilkinSerg
reviewed
Apr 9, 2020
Some tweaks to help IWYU not break this file by messing with platform-specific stuff not relevant on Linux.
ZhilkinSerg
reviewed
Apr 9, 2020
ZhilkinSerg
reviewed
Apr 9, 2020
ZhilkinSerg
reviewed
Apr 10, 2020
ZhilkinSerg
reviewed
Apr 10, 2020
|
All build variants passed - there is an unrelated test failure which can be ignored for now. |
jbytheway
added a commit
to jbytheway/Cataclysm-DDA
that referenced
this pull request
Apr 10, 2020
A last change in CleverRaven#39364 was to revert an ordering change by IWYU. Add protections to prevent the same ordering change occurring next time.
|
Thanks for all the help pushing this through :). |
kevingranade
pushed a commit
that referenced
this pull request
Apr 10, 2020
A last change in #39364 was to revert an ordering change by IWYU. Add protections to prevent the same ordering change occurring next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
To keep our headers tidy.
Describe the solution
Run IWYU, clang-tidy, and IWYU again.
Add a script intended to help people do this in the future, since it's getting a bit complicated.
Describe alternatives you've considered
One change from before is now I'm using IWYU's
--reorderfeature to sort headers alphabetically. Could have not done that.Testing
Just verified that it builds.
Additional context
There's a reasonable chance of breaking the Windows or Android builds here.