-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds post-apoc prices to all melee weapons (part 4 of reworking all prices) #39336
Merged
kevingranade
merged 5 commits into
CleverRaven:master
from
Brian-Otten:post-apoc-price-controls-4
Apr 8, 2020
Merged
Adds post-apoc prices to all melee weapons (part 4 of reworking all prices) #39336
kevingranade
merged 5 commits into
CleverRaven:master
from
Brian-Otten:post-apoc-price-controls-4
Apr 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
[JSON]
Changes (can be) made in JSON
Items / Item Actions / Item Qualities
Items and how they work and interact
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
labels
Apr 7, 2020
kevingranade
reviewed
Apr 8, 2020
kevingranade
reviewed
Apr 8, 2020
kevingranade
reviewed
Apr 8, 2020
kevingranade
reviewed
Apr 8, 2020
kevingranade
reviewed
Apr 8, 2020
kevingranade
reviewed
Apr 8, 2020
kevingranade
reviewed
Apr 8, 2020
Thanks for the review kevin, apparently i forgot to push my duplicate removal PR, but i think you might have caught one i missed. merged our fixes. |
No problemo, it was pretty quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Items / Item Actions / Item Qualities
Items and how they work and interact
[JSON]
Changes (can be) made in JSON
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "adds and balances price values on all melee weapons"
Purpose of change
The post apocalypse economy and pricing was completely out of whack and needed a full pass, i'm starting work on pricing.
It's going to be hard to compare prices for now because the current prices are so all over the place, so i'm going to have to ask for a little faith that once more of the PR's add up things will click into place and make sense.
Describe the solution
adds price_postapoc to every melee weapon (at least those listed in the melee weapons folder.).