Fix for light sources rendering the player invisible to enemies at certain ranges. #39230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
pushed a commit
to kevingranade/Cataclysm-DDA
that referenced
this pull request
Apr 9, 2020
Rivet-the-Zombie
pushed a commit
that referenced
this pull request
Apr 12, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix for light sources rendering player invisible at certain ranges."Purpose of change
Close #39166
Describe the solution
Change
range = wanted_range;torange = MAX_VIEW_DISTANCE;to prevent rounding errors.Describe alternatives you've considered
None.
Testing
Compiled with and without this change, this solves the issue.
Additional context
Thanks to kevin and anothersimulacrum for the help!