Catch std::system_error when creating and detaching melee sound thread #39112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "(Hopefully) fix a crash when playing melee sound"
Purpose of change
May fix #38875. Catch
std::system_errorso when thread creation fails, it only skips playing the sound instead of crashing.Describe the solution
Catch
std::system_errorwhen creating and detaching thread and log an error whenstd::system_erroris thrown.Testing
Spawned a debug monster and attacked it for a while, and sound was played properly. Not sure if it actually fixes the crash, but the change itself looks legitimate.