Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the "Rule of Two" #39098

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Implement the "Rule of Two" #39098

merged 1 commit into from
Mar 29, 2020

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Mar 29, 2020

Summary

SUMMARY: None

Purpose of change

Fix Inconsistent definition of copy constructor and assignment ('Rule of Two') warnings.

Describe the solution

Declare both copy assignment operator and copy constructor.

Describe alternatives you've considered

None.

Testing

It compiles.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Build Issues regarding different builds and build environments labels Mar 29, 2020
@ZhilkinSerg ZhilkinSerg merged commit 85c8c66 into CleverRaven:master Mar 29, 2020
@AMurkin AMurkin deleted the rule-of-two branch March 29, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMurkin @ZhilkinSerg