Base crit eligibility on targeted body part hp #39029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Mar 26, 2020
Merge pull request CleverRaven#39029 from kevingranade/npc-crit-bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #39008
The crit eligibility code was considering total hp instead of per body part hp, making crits vs NPCs virtually unattainable.
Describe the solution
Base eligibility on head and torso HP respectively. This falls back to total hp in monsters,
Describe alternatives you've considered
Still planning on a more nuance body model based damage system, but not at the moment.
Testing
Get a super good marksman and shoot a NPC with a reasonably damaging rifle, a crit or headshot should result.