Add pseudo-mod TEST_DATA folder and auto-load it #38945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stub in a `data/mods/TEST_DATA` folder for fake/mockup test items and other non-game data for use by test cases.
|
Already merged as part of #38936 - closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add a pseudo-mod TEST_DATA folder and auto-load it"Purpose of change
To provide a safe "test data sandbox" for any items, materials, or other stuff used by test cases, when we wish to more strictly control the data we're testing with.
Supports #38030 and #38936
Describe the solution
Adds
data/mods/TEST_DATAfolder with amodinfo.json, marked as "obsolete" with an explanation, to prevent it appearing in-game.Includes a
README.mdsummarizing the purpose of the mod.Describe alternatives you've considered
Considered putting test data in the main
data/jsonfolder, but that pollutes the main game with test items.Testing
Compiled, ran some tests. Made sure game runs, and new world creation menu does not list
TEST_DATAas one of the user-selectable mods.Additional context
This feature has been hiding away in another PR waiting on O.E, but I'm wishing I had it for some other test cases as well - hence this standalone PR.