Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more cats and kittens #38889

Merged
merged 11 commits into from
Apr 4, 2020
Merged

Add more cats and kittens #38889

merged 11 commits into from
Apr 4, 2020

Conversation

wapcaplet
Copy link
Contributor

@wapcaplet wapcaplet commented Mar 19, 2020

Summary

SUMMARY: Content "Adds more cats"

Purpose of change

To reach cat / dog parity.

Describe the solution

Adds several breeds and colorations to the cats in data/json/monsters/mammal.json, including:

Breeds:

  • Maine coon (native to Maine, fitting with the game setting)
  • Siamese
  • Persian
  • Bengal
  • Devon Rex
  • Sphynx

Colorations / variations:

  • Original "cat" is now "shorthair cat"
  • longhair cat
  • tabby
  • Calico (state cat of Maryland, again fitting)

Special:

  • "Golden chonker" - an extra-large cat (that grows from extra-hungry kittens).

Adds the new cats and kittens in roughly equal amounts as dogs to the animalpound.json and animalshelter.json monster groups in data/json/mapgen.

Describe alternatives you've considered

Letting the dogs win?

The mix of breeds, colorations, and physical attributes (chonk) when it comes to each spawning the same kind of kitten is a little nonsensical, I admit (but then so is the game's animal reproduction system in general, what with chicks spawning in fridges), so I placed greater value on having an interesting variety than on any kind of genetic realism.

Testing

Compiled and spawned a few of the new cats and kittens to make sure they work and have correct descriptions.

Spawned some animal shelters and animal pounds, saw a variety of cats.

Additional context

There are no significant differences between these cats; they are primarily to add flavor, and give tileset artists something to draw other than dogs.

Besides, I can't wait to try my Magiclysm "Bag of cats" spell with this one.

Cats seen in animal shelter:

image

@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Mar 19, 2020
@wapcaplet wapcaplet changed the title Add more cats [WIP] Add more cats Mar 19, 2020
@wapcaplet wapcaplet changed the title [WIP] Add more cats Add more cats and kittens Apr 4, 2020
@ZhilkinSerg
Copy link
Contributor

No orientals?! I am disappoincat!

@ZhilkinSerg ZhilkinSerg merged commit 9f3d7e7 into CleverRaven:master Apr 4, 2020
@wapcaplet wapcaplet deleted the more-cats branch April 12, 2020 14:45
@XygenSS XygenSS mentioned this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants